fix: truncate long reference_id to avoid DB DataError#2248
Open
Sanjay-VK07 wants to merge 1 commit intoaboutcode-org:mainfrom
Open
fix: truncate long reference_id to avoid DB DataError#2248Sanjay-VK07 wants to merge 1 commit intoaboutcode-org:mainfrom
Sanjay-VK07 wants to merge 1 commit intoaboutcode-org:mainfrom
Conversation
Signed-off-by: Sanjay <vksanjay28@gmail.com>
Sanjay-VK07
force-pushed
the
fix/reference-id-length
branch
from
521a57a to
a9c1396
Compare
Author
|
Hi, I have fixed the DCO issue and all checks are now passing. Please let me know if any further changes are needed. Thanks! |
ziadhany
requested changes
Apr 8, 2026
Collaborator
ziadhany
left a comment
ziadhany
left a comment
There was a problem hiding this comment.
@Sanjay-VK07, looks good. Could you please run the pipeline and share the logs?
Comment on lines
+131
to
+132
| MAX_REF_LEN = 200 | ||
| safe_ref_id = ref_id[:MAX_REF_LEN] if ref_id else ref_id |
Collaborator
There was a problem hiding this comment.
Can we also add "..." at the end of the truncated text to indicate that it has been shortened?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue where reference_id exceeds varchar limit causing DataError.
Closes #2190